ISPN-13181 JDK 17 changes (Nashorn) #9450

tristantarrant · 2021-07-19T09:10:02Z

https://issues.redhat.com/browse/ISPN-13181
https://issues.redhat.com/browse/ISPN-13272

tristantarrant · 2021-07-19T11:27:37Z

I'll add JDK 17 to the CI slaves as soon as PSI comes back from the dead...

tristantarrant · 2021-07-26T09:44:07Z

https://ci.infinispan.org/job/InfinispanAlternateBuilds/job/InfinispanJDKLatest/ is running against main

wburns

Changes look fine, however CI is still failing. https://ci.infinispan.org/job/InfinispanAlternateBuilds/job/InfinispanJDKLatest/80/

tristantarrant · 2021-07-26T15:55:09Z

Because that CI job is running against main. Let me redirect it

ryanemerson · 2021-08-09T10:48:56Z

It looks like Nashorn needs to be added to the client classpath for tests. There are also various IT failures.

ryanemerson · 2021-09-08T13:25:31Z

Further changes required. 74 failures atm.

tristantarrant · 2021-09-10T12:22:12Z

Please ignore the thirdparty failures as they will be fixed when WF 25 is out (https://issues.redhat.com/browse/WFCORE-5406)

tristantarrant · 2021-09-13T07:31:27Z

This is good to go. Before merging I need to remove the commit that modifies Jenkinsfile

ryanemerson

A couple of minor things, but it should be ok to remove the Jenkins commit and merge if the normal CI run is fine.

ryanemerson · 2021-09-13T08:56:03Z

.../tests/src/test/java/org/infinispan/server/security/authorization/AbstractAuthorization.java

@@ -191,6 +193,7 @@ public void testScriptUpload() {

   @Test
   public void testExecScripts() {
+      SkipJunit.skipSinceJDK(16);


Don't we still need to test this functionality with 17?

Adding the nashorn dependencies will force us to run all these tests in Container mode, but we don't have a JDK 17 container yet.

Ok. I've created ISPN-13269 so this isn't missed.

...iver/core/src/main/java/org/infinispan/server/test/core/ContainerInfinispanServerDriver.java

ryanemerson · 2021-09-13T09:29:19Z

Also, I think ISPN-13182 is the wrong Jira ID as that has already been resolved and relates to blockhound.

ryanemerson · 2021-09-13T15:49:36Z

org.infinispan.server.configuration.ServerOverlayConfigurationTest.testOverlay Is failing.

Also, shouldn't the *.thirdparty.* tests only fail with JDK 17?

tristantarrant · 2021-09-13T16:00:56Z

I did not modify the Jenkinsfile yet

ryanemerson · 2021-09-13T16:05:50Z

I did not modify the Jenkinsfile yet

Argh sorry, I should have explicitly checked that! I just saw that the number of commits had reduced and assumed.

tristantarrant · 2021-09-13T16:21:22Z

I have added a commit which fixes the NPE in org.infinispan.server.configuration.ServerOverlayConfigurationTest.testOverlay

tristantarrant · 2021-09-13T16:21:33Z

Once CI is done I'll remove the Jenkinsfile commit

tristantarrant · 2021-09-14T07:29:23Z

@ryanemerson I've repushed it without the Jenkinsfile change

ryanemerson · 2021-09-14T09:38:11Z

There's a ClassNotFoundException with org.infinispan.commons.test.skip.SkipJunit that needs to be resolved.

tristantarrant · 2021-09-14T10:09:20Z

There's a ClassNotFoundException with org.infinispan.commons.test.skip.SkipJunit that needs to be resolved.

Fixed

tristantarrant · 2021-09-14T13:16:55Z

@ryanemerson lgtm

ryanemerson · 2021-09-14T13:46:35Z

RemoteCacheMetricBinderTest is consistently failing on the last few runs and does not appear to be an issue on main.

Could you squash the NPE commits into ISPN-13181.

Also, I think ISPN-13182 is the wrong Jira ID as that has already been resolved and relates to blockhound.

This also needs addressing.

tristantarrant · 2021-09-14T14:58:24Z

Silly me: I had made a change to the default infinispan.xml file

tristantarrant · 2021-09-14T15:14:33Z

I created an extra Jira and squashed the NPE commits

ryanemerson · 2021-09-15T08:19:49Z

The four UNKNOWN.ThreadLeakChecker failures are also consistently failing on this PR and aren't present on main.

* Use the standalone Nashorn dependency * Run relevant server tests in container

* Upgrade XOM as a Workaround for Galleon plugin * Use WildFly 24.0.1

tristantarrant · 2021-09-15T09:50:55Z

The arquillian upgrade has changed the class of the ConsoleConsumer thread. I've fixed it

ryanemerson · 2021-09-15T11:44:15Z

Thanks @tristantarrant

gustavocoding · 2021-09-22T15:39:15Z

There was a possible related failure in org.infinispan.server.functional.RollingUpgradeDynamicStoreCliIT.testRollingUpgrade

wburns reviewed Jul 26, 2021

View reviewed changes

tristantarrant force-pushed the ISPN-13181/jdk17_nashorn branch 2 times, most recently from 224a7b9 to 6703923 Compare July 29, 2021 09:13

ryanemerson added the Changes Required label Aug 9, 2021

tristantarrant force-pushed the ISPN-13181/jdk17_nashorn branch from 6703923 to d6586f3 Compare August 9, 2021 14:01

tristantarrant force-pushed the ISPN-13181/jdk17_nashorn branch from d6586f3 to 8064a5f Compare September 8, 2021 11:46

tristantarrant removed the Changes Required label Sep 8, 2021

tristantarrant changed the title ~~ISPN-13181 + ISPN-13182 JDK 17 changes (Nashorn + BlockHound)~~ ISPN-13182 JDK 17 changes (Nashorn) Sep 8, 2021

ryanemerson added the Changes Required label Sep 8, 2021

tristantarrant force-pushed the ISPN-13181/jdk17_nashorn branch from 25e8bea to a3dabf6 Compare September 9, 2021 15:37

tristantarrant force-pushed the ISPN-13181/jdk17_nashorn branch from 2ddbb0c to f83fd5c Compare September 10, 2021 15:08

ryanemerson reviewed Sep 13, 2021

View reviewed changes

tristantarrant changed the title ~~ISPN-13182 JDK 17 changes (Nashorn)~~ ISPN-13181 JDK 17 changes (Nashorn) Sep 13, 2021

tristantarrant force-pushed the ISPN-13181/jdk17_nashorn branch from f83fd5c to 7e15e56 Compare September 13, 2021 10:07

tristantarrant force-pushed the ISPN-13181/jdk17_nashorn branch from 5db0805 to c506e60 Compare September 14, 2021 07:29

tristantarrant force-pushed the ISPN-13181/jdk17_nashorn branch from c506e60 to db1bf22 Compare September 14, 2021 10:08

tristantarrant removed the Changes Required label Sep 14, 2021

tristantarrant force-pushed the ISPN-13181/jdk17_nashorn branch from db1bf22 to f5179ec Compare September 14, 2021 14:57

tristantarrant force-pushed the ISPN-13181/jdk17_nashorn branch from f5179ec to 72b5b53 Compare September 14, 2021 15:14

tristantarrant added 2 commits September 15, 2021 11:50

ISPN-13181 Nashorn JDK 17

18779eb

* Use the standalone Nashorn dependency * Run relevant server tests in container

ISPN-13272 Fix WildFly provisioning and tests

d45462d

* Upgrade XOM as a Workaround for Galleon plugin * Use WildFly 24.0.1

tristantarrant force-pushed the ISPN-13181/jdk17_nashorn branch from 72b5b53 to d45462d Compare September 15, 2021 09:50

ryanemerson merged commit b075d48 into infinispan:main Sep 15, 2021

tristantarrant deleted the ISPN-13181/jdk17_nashorn branch July 5, 2022 09:58

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ISPN-13181 JDK 17 changes (Nashorn) #9450

ISPN-13181 JDK 17 changes (Nashorn) #9450

tristantarrant commented Jul 19, 2021 •

edited

tristantarrant commented Jul 19, 2021

tristantarrant commented Jul 26, 2021

wburns left a comment

tristantarrant commented Jul 26, 2021

ryanemerson commented Aug 9, 2021

ryanemerson commented Sep 8, 2021

tristantarrant commented Sep 10, 2021

tristantarrant commented Sep 13, 2021 •

edited

ryanemerson left a comment

ryanemerson Sep 13, 2021

tristantarrant Sep 13, 2021

ryanemerson Sep 13, 2021

ryanemerson commented Sep 13, 2021

ryanemerson commented Sep 13, 2021

tristantarrant commented Sep 13, 2021

ryanemerson commented Sep 13, 2021

tristantarrant commented Sep 13, 2021

tristantarrant commented Sep 13, 2021

tristantarrant commented Sep 14, 2021

ryanemerson commented Sep 14, 2021

tristantarrant commented Sep 14, 2021

tristantarrant commented Sep 14, 2021

ryanemerson commented Sep 14, 2021

tristantarrant commented Sep 14, 2021

tristantarrant commented Sep 14, 2021

ryanemerson commented Sep 15, 2021

tristantarrant commented Sep 15, 2021

ryanemerson commented Sep 15, 2021

gustavocoding commented Sep 22, 2021

ISPN-13181 JDK 17 changes (Nashorn) #9450

ISPN-13181 JDK 17 changes (Nashorn) #9450

Conversation

tristantarrant commented Jul 19, 2021 • edited

tristantarrant commented Jul 19, 2021

tristantarrant commented Jul 26, 2021

wburns left a comment

Choose a reason for hiding this comment

tristantarrant commented Jul 26, 2021

ryanemerson commented Aug 9, 2021

ryanemerson commented Sep 8, 2021

tristantarrant commented Sep 10, 2021

tristantarrant commented Sep 13, 2021 • edited

ryanemerson left a comment

Choose a reason for hiding this comment

ryanemerson Sep 13, 2021

Choose a reason for hiding this comment

tristantarrant Sep 13, 2021

Choose a reason for hiding this comment

ryanemerson Sep 13, 2021

Choose a reason for hiding this comment

ryanemerson commented Sep 13, 2021

ryanemerson commented Sep 13, 2021

tristantarrant commented Sep 13, 2021

ryanemerson commented Sep 13, 2021

tristantarrant commented Sep 13, 2021

tristantarrant commented Sep 13, 2021

tristantarrant commented Sep 14, 2021

ryanemerson commented Sep 14, 2021

tristantarrant commented Sep 14, 2021

tristantarrant commented Sep 14, 2021

ryanemerson commented Sep 14, 2021

tristantarrant commented Sep 14, 2021

tristantarrant commented Sep 14, 2021

ryanemerson commented Sep 15, 2021

tristantarrant commented Sep 15, 2021

ryanemerson commented Sep 15, 2021

gustavocoding commented Sep 22, 2021

tristantarrant commented Jul 19, 2021 •

edited

tristantarrant commented Sep 13, 2021 •

edited